Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: swallow expect.soft errors inside successful toPass matcher #20509

Merged
merged 4 commits into from
Feb 2, 2023
Merged

fix: swallow expect.soft errors inside successful toPass matcher #20509

merged 4 commits into from
Feb 2, 2023

Conversation

aslushnikov
Copy link
Collaborator

Fixes #20437

dgozman
dgozman approved these changes Jan 31, 2023
View reviewed changes
tests/playwright-test/expect-to-pass.spec.ts Show resolved Hide resolved
packages/playwright-test/src/common/testInfo.ts Outdated Show resolved Hide resolved
packages/playwright-test/src/matchers/matchers.ts Outdated Show resolved Hide resolved
packages/playwright-test/src/matchers/matchers.ts Outdated Show resolved Hide resolved
packages/playwright-test/src/matchers/matchers.ts Outdated Show resolved Hide resolved
@aslushnikov aslushnikov merged commit 4f61105 into microsoft:main Feb 2, 2023
@aslushnikov aslushnikov deleted the special-treatment-for-soft-asserts-inside-topass branch February 2, 2023 18:47
@pavelfeldman pavelfeldman mentioned this pull request Apr 6, 2023
Closed
1 task
@yury-s yury-s mentioned this pull request Apr 6, 2023
Merged
aslushnikov pushed a commit that referenced this pull request Apr 11, 2023
@pavelfeldman
revert(20509, 20596): expect.toPass is broken with these (#22254)
c5aeab4 
Reverts #20509 and
#20596
Fixes #22215
aslushnikov pushed a commit that referenced this pull request Apr 11, 2023
@pavelfeldman @aslushnikov
cherry-pick(#22254): revert(20509, 20596): expect.toPass is broken wi…
710674a 
…th these

Reverts #20509 and
#20596
Fixes #22215
sand4rt pushed a commit to sand4rt/playwright that referenced this pull request Apr 19, 2023
@pavelfeldman @sand4rt
revert(20509, 20596): expect.toPass is broken with these (microsoft#2…
d9d4f7b 
…2254)

Reverts microsoft#20509 and
microsoft#20596
Fixes microsoft#22215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Expect.toPass to work with soft asserts
2 participants
@aslushnikov @dgozman